search

boxen / our-boxen

Copy me for your team.
https://github.com/boxen/our-boxen/
MIT License
2.58k stars 882 forks source link

Puppet-Github-Mac #108

Closed kevinSuttle closed 11 years ago

kevinSuttle commented 11 years ago

https://github.com/kevinSuttle/puppet-github-mac

wfarr commented 11 years ago

Same deal as the others. Left you some comments. Clean 'em up, ping me, and we'll get this forked under the org. :smile:

ocxo commented 11 years ago

Can we have this module re-named "github" instead of "github-mac"? I think this would be more consistent with the other boxen modules which are not appended with "mac". https://github.com/articulate/puppet-github

kevinSuttle commented 11 years ago

Cleaned up and renamed: https://github.com/kevinSuttle/puppet-github

kevinSuttle commented 11 years ago

Also, @fromonesrc I didn't see @articulate's. Should I add boxen as a required module?

ocxo commented 11 years ago

No problem! You got yours in first so let's use that.

I'm not sure if boxen is actually a required puppet module in this case. I left it in the readme based off the template because I wasn't sure what it would mean to say it's not required. But since it works fine without me adding anything to explicitly require it, I think it's safe to leave it out.

kevinSuttle commented 11 years ago

Very cool. Thanks!

wfarr commented 11 years ago

Hm. Not sure about the name puppet-github — mostly because it would conflict with our own github module inside our org :wink:

Maybe githubapp?

kevinSuttle commented 11 years ago

I can do that!

kevinSuttle commented 11 years ago

Done. https://github.com/kevinSuttle/puppet-githubapp

jhubert commented 11 years ago

I actually think you had it right the first time with puppet-github-mac because that's actually what it installs: "Github for Mac."

ocxo commented 11 years ago

Not a big deal but I proposed just plain old "github" because none if the other mac app modules are appended with "-mac" even though they are for the Mac. I'm happy either way as long as it works :)

On Mar 7, 2013, at 8:14 PM, Jeremy Baker notifications@github.com wrote:

I actually think you had it right the first time with puppet-github-mac because that's actually what it installs: "Github for Mac."

— Reply to this email directly or view it on GitHub.

kevinSuttle commented 11 years ago

I think Github-App is good. Boxen only runs on Mac so it doesn't need the redundancy, and is more specific than what because of what @wfarr said above.

kevinSuttle commented 11 years ago

Er, githubapp. What's the convention with dashes?

jhubert commented 11 years ago

Fair 'nuff. I suppose I've always referred to the GitHub app as "GitHub for Mac", as opposed to something like Sparrow which is just Sparrow. I think it's mostly about how GitHub branded it though and possibly just my silly memory instead of what it's actually referred to.

As for dashes, I've seen underscores used instead of dashes. ex: sublime_text_2 and notational_velocity.

ocxo commented 11 years ago

No you're right it is branded GitHub for Mac. Flip a coin and ship it.

Use underscores to represent spaces and use dashes as namespace separators.

kevinSuttle commented 11 years ago

Would github_for_mac be the best choice here?

jhubert commented 11 years ago

Sounds great to me. :+1:

kevinSuttle commented 11 years ago

Updated. https://github.com/kevinSuttle/puppet-github_for_mac

kevinSuttle commented 11 years ago

Bump. Decision on this? Merge or does it belong to Github for maintenance?

ocxo commented 11 years ago

github_for_mac is fine :ship: :ship: :ship:

kevinSuttle commented 11 years ago

Bump?

ocxo commented 11 years ago

:package: :+1: https://github.com/boxen/puppet-github_for_mac