search

boxen / our-boxen

Copy me for your team.
https://github.com/boxen/our-boxen/
MIT License
2.58k stars 883 forks source link

Remove Puppetfile.lock from repository #799

Closed sambauers closed 8 years ago

sambauers commented 8 years ago

There is no need for this file in the repository as all the version numbers are locked in Puppetfile itself.

In our setup, where we have copied our-boxen into a non-forked private repository, merging the Puppetfile.lock is a real pain, and ultimately useless as we just regenerate it with a librarian-puppet install run anyway.

jacobbednarz commented 8 years ago

Thanks for the feedback @sambauers. I'm not really comfortable removing the Puppetfile.lock from the repository since it is good for the majority of people who are just forking the vanilla our-boxen setup and possibly not running librarian-puppet locally.

If you are having issues maintaining a forked version, I'd recommend checking out the FAQ article on upgrading as it gives quite a good approach on handling the situation you've described.

I'm going to close this one off but I'm happy to answer any questions you may have.