search

boxen / our-boxen

Copy me for your team.
https://github.com/boxen/our-boxen/
MIT License
2.58k stars 883 forks source link

Created a golang module #809

Closed cbelk closed 8 years ago

cbelk commented 8 years ago

https://github.com/cbelk/cbelk-golang

Module for barebones Go installation. Go downloaded from Google.

jacobbednarz commented 8 years ago

Thanks for your contribution @cbelk! While this is a great start, I think there are a few of things that need to be mentioned here:

  1. go can already be installed quite painlessly with homebrew so a module really isn't required.
  2. Your module makes some assumptions (such as that everyone is using bash for their shell) which will cause some issues for other shell users.
  3. Your module is missing tests. Tests help ensure that your module works as intended across different installations. Check out puppet-ruby specs for some examples.

I'm going to close this one off but feel free to let me know if you have any questions!