search

boxen / our-boxen

Copy me for your team.
https://github.com/boxen/our-boxen/
MIT License
2.58k stars 884 forks source link

Upgrade puppet-brewcask dependency #825

Closed jabley closed 7 years ago

jabley commented 7 years ago

It looks like something has changed in the ecosystem. I started seeing errors running boxen:

Error: Execution of 'brew boxen-latest brew-cask' returned 1: Error: No available formula with the name "brew-cask"
Error: /Stage[main]/Brewcask/Package[brew-cask]/ensure: change from absent to present failed: Execution of 'brew boxen-latest brew-cask' returned 1: Error: No available formula with the name "brew-cask"

And all of my boxen::personal::osx_apps would be skipped.

This change reflects the fact that cask now comes with brew now.

jabley commented 7 years ago

Fixes #824.

jacobbednarz commented 7 years ago

I'm not convinced this is going to solve the issue as the version bump only manages the brewcask tasks within homebrew itself. Would you be able to elaborate a little more on your reasoning here? I'm all for getting this updated regardless but I don't want to close off #824 if it's not related.

Have you also tried brew update && brew upgrade to ensure it's not something to do with an outdated homebrew installation?

happicamper commented 7 years ago

Had experienced that last week but after seeing the latest puppet-brewcask version, I changed my Puppetfile same as the changes of @jabley then it solves the problem.

jacobbednarz commented 7 years ago

My side thought here is that the Puppetfile change may have initiated the update/upgrade itself so version bumping was an indirect fix. Does that make sense? For what it's worth, I haven't delved too deep into that code (yet!) but plan to in the coming months so either way I'm happy here.

jabley commented 7 years ago

brew update && brew upgrade had not fixed this for me, hence the reason I went digging and found the change in the puppet module.

Also saw the problem on multiple machines.