search

boxen / our-boxen

Copy me for your team.
https://github.com/boxen/our-boxen/
MIT License
2.58k stars 884 forks source link

bootstrap hooks #845

Closed akalman closed 6 years ago

akalman commented 7 years ago

This will give very basic support for hooks during bootstrap.

I went with something as simple as possible since I have basically no data revolving around use cases. There's a lot that's missing here, hooks based on user, having hooks load from dependent ruby/puppet modules, only running under certain conditions if we really want to create a "puppet-like" experience. But this will get the job done.

I went with a directory over a naming convention because I thought it'd be harder to get wrong and puppet already has semantic directory structures. Although I suppose it also has semantic names as well since boxen loads files with specific names by default.

akalman commented 7 years ago

this was created in response to issue #842

akalman commented 7 years ago

actually wait a bit for this. In a fit of delirium I forgot to test to this to make sure it works.

jacobbednarz commented 7 years ago

Thanks for this @akalman! Let me know when you're ready for a review and I'll take a look.

akalman commented 7 years ago

ok consider this haphazardly tested!

akalman commented 7 years ago

@jacobbednarz any update on this?

jacobbednarz commented 7 years ago

I've been going back and forth with myself on this for the last week trying to weigh up the pros and cons because this has the potential to slow down Boxen runs if we're not careful about it.

jacobbednarz commented 6 years ago

@akalman is this still something you're interested in landing?