search

boxen / our-boxen

Copy me for your team.
https://github.com/boxen/our-boxen/
MIT License
2.58k stars 882 forks source link

Fix CI details #862

Closed jacobbednarz closed 6 years ago

jacobbednarz commented 6 years ago

Pulls over the commits from #861 and use the secure credentials and actually run successfully.

jacobbednarz commented 6 years ago

OK, so the last failure is a legit one due to GitHub disabling older versions of TLS and I've outlined at https://github.com/boxen/boxen/issues/221. I'm still working on this but will post some updates there.

jacobbednarz commented 6 years ago

This PR is going to be blocked until I've fixed Boxen to be High Sierra only (per https://github.com/boxen/boxen/issues/221#issuecomment-369721631).

jacobbednarz commented 6 years ago

@n0ts I've removed your changes to the gemrc file (via d5ed644) since that don't have any impact on whether or not we can connect to a service that is TLSv1.2 enabled.

The only fix that will move this forward is upgrading to High Sierra and fixing the issues mentioned at boxen/boxen#222

jacobbednarz commented 6 years ago

Fixed in #863