search

boxen / puppet-dnsmasq

Install the dnsmasq DNS forwarder.
http://boxen.github.com
MIT License
9 stars 29 forks source link

Overriding config file #15

Open erik-stephens opened 9 years ago

erik-stephens commented 9 years ago

Issue #5 references a way to override the config via dnsmasq::config class but that class was removed. There is reference to a $configfile param but it is not used. I'm going to fix in my personal fork. If would like me to submit a PR, help me understand how $configfile was intended to be used: a source, a template, or something else entirely?

msturm commented 9 years ago

Hi, What is the plan to fix the overriding of the dnsmasq.conf file? Because now I have to do a bit of a nasty hack to add additional entries to this file, but a nice way to override it would be cool... The repository of erik-stephens doesn't work, because it doesn't start dnsmasq with the correct config file (that is probably the reason why that $configfile variable is still there...)

erik-stephens commented 9 years ago

Yeah, not sure why I commented out $configfile in my fork, maybe to indicate that it's not used. I think I searched for $configfile but after looking again, I see it referenced in an erb template as @configfile - lesson learned when grep'ing puppet modules. Not tested but I did undo that comment so the daemon should start now.

Longer term, maybe have the config file driven by a hash variable? I'm not sure worth the effort. Putting the onus of managing the config file on the boxen user and not this module might be best.