search

boxen / puppet-dnsmasq

Install the dnsmasq DNS forwarder.
http://boxen.github.com
MIT License
9 stars 29 forks source link

Fix inconsistent service name #24

Closed gblair closed 6 years ago

gblair commented 6 years ago

When the new tld option was introduced (awesome, BTW!), the name of the service became tied to the TLD used. However, "dev" is hard-coded as a service name prefix in the boxen gem. Also, we could conceivably add more TLDs to our Dnsmasq setup, but we won't run a separate service for each one. Lastly, it might be nice to stick with the convention observed in other boxen-managed services where the service name is not tied to the configuration of the service.

jacobbednarz commented 6 years ago

Thanks for this! Past Jacob seems to have ignored the advice given at https://github.com/boxen/puppet-dnsmasq/pull/17#discussion_r31087263.

jacobbednarz commented 6 years ago

Released in 2.0.5. Much appreciated! :cake: