boxen / puppet-eclipse

Eclipse Puppet Module for Boxen
MIT License
0 stars 11 forks source link

initial support for Luna. Extracted Release and Mirror to parameters #8

Closed jbcpollak closed 10 years ago

jbcpollak commented 10 years ago

I bumped to Luna, necessary for Java 8 support. I made the release and mirror configurable in case people would like to backdate to stick with Kepler or try out Mars.

dieterdemeyer commented 10 years ago

@jbcpollak Thanks for the PR. Can you update the spec tests as well ?

jbcpollak commented 10 years ago

Hello,

I've pushed an update. This is my first time working with Puppet (or any Ruby) tests. I needed to update the Boxen version to get past an error about being unable to find the project on GitHub.

When I run the project locally, the modules fail with this error:

  1) eclipse::cpp 
     Failure/Error: should contain_package('Eclipse-CPP-luna-R').with({
     Puppet::Error:
       Could not autoload puppet/type/package: constant Puppet::Type::Package not defined on node belka.home
     # ./spec/classes/eclipse_cpp_spec.rb:5:in `block (2 levels) in <top (required)>'

These links:

https://bugzilla.redhat.com/show_bug.cgi?id=927298 http://leafac.com/bugs/2013/05/02/problems-with-puppet-in-ruby-2-0.html

Tell me it is an issue with Ruby 2.0 and Puppet 3.1.1, but I can't figure out how to set the Puppet version to 3.2 in the tests.

I tried using Ruby 2.1.2 via rbenv, but this caused a different error. I suspect the only way to work around this issue is upgrading the Puppet version used in the spec, but I don't know how to do that.

jbcpollak commented 10 years ago

Figured out the problem, cardboard was out of date, then I fixed the tests.