boxen / puppet-java

Install Java
http://boxen.github.com
MIT License
13 stars 55 forks source link

Support for Java 7 Update 65, please #42

Closed johnsyweb closed 10 years ago

johnsyweb commented 10 years ago

Java 7 Update 65 is available from http://www.oracle.com/technetwork/java/javase/downloads/jdk7-downloads-1880260.html and I tried to update via Boxen:

diff --git a/hiera/common.yaml b/hiera/common.yaml
index 703337a..b6a4cce 100644
--- a/hiera/common.yaml
+++ b/hiera/common.yaml
@@ -14,4 +14,4 @@ ruby::version::alias:
   2.0.0: 2.0.0-p353

 # See https://github.com/boxen/puppet-java for docs
-java::update_version: 55
+java::update_version: 65

This resulted in failures because:

% curl -I https://s3.amazonaws.com/boxen-downloads/java/jre-7u65-macosx-x64.dmg
HTTP/1.1 403 Forbidden
x-amz-request-id: 32CD5A0CD0A59B30
x-amz-id-2: wW7P3+twirv2AVE6zVYIcoeZoO0gIcmM4Ae7Mg4RYLhfLJgmWoRWzoSaFTyLxPUd
Content-Type: application/xml
Transfer-Encoding: chunked
Date: Wed, 23 Jul 2014 00:43:30 GMT
Server: AmazonS3

Could we please have access to this package?

dgoodlad commented 10 years ago

@johnsyweb I'll definitely get that uploaded ASAP. I don't always notice when new JRE/JDK releases get made, so if you need an update and it's not on the boxen-downloads s3 bucket, you should be able to put the dmg somewhere else that you control and set java::base_download_url to something suitable. See https://github.com/boxen/puppet-java/blob/3a2a77341570509aebf1ef92018cf9ee39e75ae2/manifests/init.pp#L8

The idea behind a lot of the recent changes to the core boxen modules is to reduce your dependency on the maintainers releasing new module versions to track upstream. Let me know if you find anywhere else that keeps you stuck on an old upstream release just because you're waiting on a maintainer, and we'll get it sorted out!

dgoodlad commented 10 years ago

Also, the 403 is just S3 forbidding access to missing objects, it doesn't throw a 404 on missing objects in buckets where the overall bucket is not anonymously accessible. I didn't lock you out, I promise!

johnsyweb commented 10 years ago

Thanks @dgoodlad, I appreciate it :-)

dgoodlad commented 10 years ago

@johnsyweb Done and done.

~ » curl -I https://s3.amazonaws.com/boxen-downloads/java/jre-7u65-macosx-x64.dmg
HTTP/1.1 200 OK
x-amz-id-2: D9nWaG1KVbvVr+GyOv0oxxW1lVi0b1Xr0Byspo1vIFDfjyFn+V8RB7seIS7MDMZM
x-amz-request-id: 7772FEAAF18C9908
Date: Wed, 23 Jul 2014 17:41:03 GMT
Last-Modified: Wed, 23 Jul 2014 05:25:52 GMT
ETag: "d82293588db948aeebdb2392e67eca8b"
Accept-Ranges: bytes
Content-Type: application/octet-stream
Content-Length: 50901723
Server: AmazonS3

~ » curl -I https://s3.amazonaws.com/boxen-downloads/java/jdk-7u65-macosx-x64.dmg
HTTP/1.1 200 OK
x-amz-id-2: 46cIf/0pnW7K+vXqoCBvnKYAXK0fuYuyuG4flXRUWWiIIf3IrbABy/JURVpYF5Nn
x-amz-request-id: EFA2EA104015927C
Date: Wed, 23 Jul 2014 17:41:26 GMT
Last-Modified: Wed, 23 Jul 2014 17:17:34 GMT
ETag: "fbdcfb5f50372c8fad3293b126d7e50d"
Accept-Ranges: bytes
Content-Type: application/octet-stream
Content-Length: 195045228
Server: AmazonS3
johnsyweb commented 10 years ago

Thanks @dgoodlad!