search

boxen / puppet-mongodb

MIT License
9 stars 35 forks source link

Error on build #23

Closed jenslind closed 9 years ago

jenslind commented 9 years ago

I am unable to build mongodb on 10.10.3 with latest CLT installed (6.3.1). Seems to be this issue: https://jira.mongodb.org/browse/SERVER-15182 Probably the clang version that has been updated on the latest CLT.

I am able to install mongodb 3.x without issues. Probably need to update the mongodb version?

jenslind commented 9 years ago

Made an pull-request, not sure if this is the way to go though!

https://github.com/boxen/puppet-mongodb/pull/24

dannyfallon commented 9 years ago

The problem is with Clang v3.5+ on Yosemite with MongoDB 2.6.x/2.4.x. I opened up a ticket with MongoDB [SERVER-18135] and backported the same fixes they applied to 3.0 in https://github.com/mongodb/mongo/pull/956 but they closed it without a merge. Like it says in that PR, the proper fix is to just use the --disable-warnings-as-errors build flag.

Rather than update to the latest version I suggest that this is the route we should take until we can make the mongo DB version configurable - I think some people (including myself) would really like the option to pick the mongo DB version rather than steamroll ahead on 3.0 to get around build issues on a specific OS X version :smile:

jenslind commented 9 years ago

Yeah you are probably right about adding the --disable-warnings-as-errors flag to fix this for now. However, if upgrading to 3.0.2 we get rid of some patches which is needed now to add yosemite support. And yes it would be great to be able to pick a specific version! :)

dannyfallon commented 9 years ago

Yep, there are benefits to being on the latest and greatest versions. As a 2.6 user for which this module is currently broken for I'd really like it fixed for 2.6 first before an upgrade to 3.0 so I don't have to fork and do the fix myself :smile:

I think those patches are not needed if you update to 2.6.9 (the latest stable 2.6 release). I know that the only modification I had to make to MongoDB source to build is the addition on the flag I mentioned. I'll submit a PR adding the flag, a separate one to upgrade to 2.6.9 and we'll let the maintainers decide the merge order

jenslind commented 9 years ago

Sounds good! :+1: