search

boxen / puppet-nodejs

MIT License
15 stars 47 forks source link

Fix node modules npm 1.4.3 #32

Closed park9140 closed 10 years ago

park9140 commented 10 years ago

In npm 1.4.3 and beyond listing a globally installed dependency will return with code 1 not 0. This allows global modules to be installed in the new node v0.10.26.

mroth commented 10 years ago

Thank you! This issue has been driving me crazy. Hope this gets merged soon. :bow:

mroth commented 10 years ago

@rafaelfranca could you please take a look at this one? (with this and #30 this module should actually work as advertised in the documentation again)

aripalo commented 10 years ago

So I guess this is the reason for:

Error: /Stage[main]/Main/Node[default]/Nodejs::Module[grunt-cli]/Npm_module[grunt-cli]: Could not evaluate: Could not list node packages: Execution of '/opt/boxen/nodenv/shims/npm list --global grunt-cli --json --silent' returned 1: {}

Would be nice to get this PR merged soon!

rafaelfranca commented 10 years ago

Ack! I'll take a look tomorrow

skottler commented 10 years ago

Works nicely for me. Thanks for the contribution!