Closed blackjid closed 10 years ago
You did that for the ruby module right? mmm, those version classes are a maintenance nightmare.. :) I think they can be removed....
Probabley in the readme we should change the
# install any arbitrary nodejs version
nodejs { 'v0.10.1': }
with
# install any arbitrary nodejs version
nodejs::version { 'v0.10.1': }
Yes. we need to update the readme too.
something like that?
One more step we can do is make possible to configure these aliases versions using hiera so we don't need to add a new class if node 0.12 is released.
That will require more work/time. :) I have never quite understood how hiera works. But may be is a good time to learn... I will look to the ruby module.
@rafaelfranca ok, finally. The ruby module was a lot of help..
@rafaelfranca A few more fixes, to set if will install compiling from source or not... I thinks that this should be it... It is working for me at least... :)
@rafaelfranca don't forget this PR, please :)
Seems good. Just need a rebase. Could you take a look?
Rebased, do you want me to squash it into few commits?
@rafaelfranca ?? have you had any time?
I didn't saw you rebase. Thanks. I'll release later when I test it locally
:+1:
Does this add support for setting nodejs::global using Hiera? If it does, can you add it to the readme? If not, ðŸ˜
nop, it doesn't. I mainly based my work on the boxen/puppet-ruby
module, and that one doesn't support global using hiera either... sorry
We could remove all the version class but the aliases. WDYT?