boxen / puppet-nodejs

MIT License
15 stars 47 forks source link

Global, local and module not rely on version classes to work anymore #38

Closed blackjid closed 10 years ago

rafaelfranca commented 10 years ago

We could remove all the version class but the aliases. WDYT?

blackjid commented 10 years ago

You did that for the ruby module right? mmm, those version classes are a maintenance nightmare.. :) I think they can be removed....

Probabley in the readme we should change the

# install any arbitrary nodejs version
nodejs { 'v0.10.1': }

with

# install any arbitrary nodejs version
nodejs::version { 'v0.10.1': }
rafaelfranca commented 10 years ago

Yes. we need to update the readme too.

blackjid commented 10 years ago

something like that?

rafaelfranca commented 10 years ago

One more step we can do is make possible to configure these aliases versions using hiera so we don't need to add a new class if node 0.12 is released.

blackjid commented 10 years ago

That will require more work/time. :) I have never quite understood how hiera works. But may be is a good time to learn... I will look to the ruby module.

blackjid commented 10 years ago

@rafaelfranca ok, finally. The ruby module was a lot of help..

blackjid commented 10 years ago

@rafaelfranca A few more fixes, to set if will install compiling from source or not... I thinks that this should be it... It is working for me at least... :)

blackjid commented 10 years ago

@rafaelfranca don't forget this PR, please :)

rafaelfranca commented 10 years ago

Seems good. Just need a rebase. Could you take a look?

blackjid commented 10 years ago

Rebased, do you want me to squash it into few commits?

blackjid commented 10 years ago

@rafaelfranca ?? have you had any time?

rafaelfranca commented 10 years ago

I didn't saw you rebase. Thanks. I'll release later when I test it locally

blackjid commented 10 years ago

:+1:

indirect commented 10 years ago

Does this add support for setting nodejs::global using Hiera? If it does, can you add it to the readme? If not, 😭

blackjid commented 10 years ago

nop, it doesn't. I mainly based my work on the boxen/puppet-ruby module, and that one doesn't support global using hiera either... sorry

rafaelfranca commented 9 years ago

Released as https://github.com/boxen/puppet-nodejs/releases/tag/4.0.0