search

boxen / puppet-nodejs

MIT License
15 stars 47 forks source link

remove relative node_modules .bin from PATH #63

Closed msuess closed 8 years ago

msuess commented 8 years ago

Having './node_modules/.bin' on the PATH breaks react-native and causes other NPM modules to be confused as to where they are installed (ie. phantomjs). Maybe it's best to leave this decision to the user instead of having it as default. This is not really boxen-specific behaviour anyway and is not needed to run nodejs via boxen.

eugeneius commented 8 years ago

This configuration was added in https://github.com/boxen/puppet-nodejs/pull/19, removed in https://github.com/boxen/puppet-nodejs/pull/48, and added again in https://github.com/boxen/puppet-nodejs/pull/56.

If we're going to change it again I think it needs to be configurable.

msuess commented 8 years ago

Isn't it already configurable in the sense that the user can add it to his or her PATH if they choose to?

blackjid commented 8 years ago

@msuess I think you are right... It also makes difficult the use of globally installed packages.

what do you think @DanielWright??? I merged your PR, and I would love to hear you thoughts...

DanielWright commented 8 years ago

I agree with @msuess. I was wrong to readd the old behaviour in my PR; it's unexpected and difficult to disable.

webflo commented 8 years ago

@blackjid Could you tag a new release? Thanks!