search

boxen / puppet-php

PHP ALL THE BOXEN
boxen.github.com
MIT License
11 stars 29 forks source link

Don't Redownload Composer #55

Closed mloberg closed 9 years ago

mloberg commented 9 years ago

There's been some really good changes in composer (https://github.com/composer/composer/commit/ac676f47f7bbc619678a29deae097b6b0710b799) that make it tons faster then before, but running Boxen will revert composer to before these changes. So instead of forcing a version, just leave composer alone if it's already installed.

mattheath commented 9 years ago

Thanks @mloberg, this looks fine - though we could tighten up the unless condition to use creates as we're only checking for file existence now?

Also might be worth bumping the version to alpha9 so this change is included if the user doesn't have composer already?

mloberg commented 9 years ago

It was a quick fix, but creates makes more sense. I'll update it.

With this change though, any users with existing composer installs will stay at alpha8. One option might be using hiera which would allow a default, but could also be be overridden by the user. On Jan 5, 2015 6:35 PM, "Matt Heath" notifications@github.com wrote:

Thanks @mloberg https://github.com/mloberg, this looks fine - though we could tighten up the unless condition to use creates as we're only checking for file existence now?

Also might be worth bumping the version to alpha9 so this change is included if the user doesn't have composer already?

Reply to this email directly or view it on GitHub https://github.com/boxen/puppet-php/pull/55#issuecomment-68807949.

mattheath commented 9 years ago

Hiera would be ideal, but it would likely be a bit more work to update now. Happy for that to be done separately if someone (you? :wink:) wants to pick it up.

mloberg commented 9 years ago

I could definitely start some work on it when I have some time.

sambauers commented 9 years ago

Hiera for configs is part of the nascent v2.0 plans - https://github.com/boxen/puppet-php/pull/56 - maybe contribute changes to the v2 branch to override composer version and checksum?

mattheath commented 9 years ago

That would be perfect :+1:

sambauers commented 9 years ago

I've made an attempt at this via Hiera configs in my existing v2 branch PR. Changeset is here - https://github.com/sambauers/puppet-php/commit/84612e76c1d2424e826814f0333de6acece866d5

sambauers commented 9 years ago

This is covered in the v2 branch now, suggest we close this.

mloberg commented 9 years ago

Sounds good to me.