search

boxen / puppet-php

PHP ALL THE BOXEN
boxen.github.com
MIT License
11 stars 29 forks source link

Update composer to 1.2.0 #88

Closed alexmace closed 8 years ago

jacobbednarz commented 8 years ago

Where did you get the checksum from? I get different results for the 1.2.0 release.

$ md5 -q ~/Downloads/composer.phar
df47dc307fa614daa5a10423bdf4e1bb
alexmace commented 8 years ago

I used shasum to generate the hash:

% shasum ~/Downloads/composer.phar !10484 ad898f510e1a7909fe251d2193a8cca1257e9dd4 /Users/amace/Downloads/composer.phar

I’m assuming this is correct since it installs without complaining about the checksum, but I haven’t looked under the hood to ensure that is how it is calculated.

On 7 Sep 2016, at 06:29, Jacob Bednarz notifications@github.com wrote:

Where did you get the checksum from? I get different results for the 1.2.0 release.

$ md5 -q ~/Downloads/composer.phar df47dc307fa614daa5a10423bdf4e1bb — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/boxen/puppet-php/pull/88#issuecomment-245179130, or mute the thread https://github.com/notifications/unsubscribe-auth/AAMqH6NxghsS4xbSk2RMWE_u1xXrt52pks5qnku8gaJpZM4J1svG.

alexmace commented 8 years ago

Ah, I've looked under the hood now and I can see it only uses the checksum to see if it should download composer again, and it does indeed use md5. I'll update the PR.

jacobbednarz commented 8 years ago

LGTM :ship: