boxen / puppet-php

PHP ALL THE BOXEN
boxen.github.com
MIT License
11 stars 29 forks source link

PHP install fails on openssl error #96

Open convenient opened 7 years ago

convenient commented 7 years ago

Sorry I've lost the actual error that is output when running boxen, it slid off of the top of my terminal sorry!

You can see the changes in the oddhill fork which fixed the installation for me on el capitan. https://github.com/boxen/puppet-php/compare/master...oddhill:master

typhonius commented 7 years ago

In order to get the AmpersandHQ/puppet-php build working, I had to make some modifications that I've committed to typhonius/puppet-php in order to remove some assumptions.

I'd be interested to get feedback on whether this is the correct approach but it allowed me to build PHP 7.0.13 on my Mac Sierra system.

jacobbednarz commented 7 years ago

Do either of you mind opening a PR against this repository for easier inspection and validation?

typhonius commented 7 years ago

I've created a PR based on my fork (which is based on @AmpersandHQ fork) in #97

convenient commented 7 years ago

Thanks for handling this @typhonius

I didn't submit a PR as I wasn't too sure as to what @oddhill had actually modified in their fork, only that it worked for our systems :)