search

boxen / puppet-virtualbox

MIT License
9 stars 60 forks source link

Adds onlyif attribute to 'Kill Virtual Box Processes' #15

Closed mnussbaum closed 10 years ago

mnussbaum commented 10 years ago

This prevents the "kill processes" exec from running and the resulting notice from printing every run by only triggering the kill command when necessary.

gingermusketeer commented 10 years ago

Is this the reason why the vms that i have running are killed when running boxen? Is it not only necessary to run the kill if virtual box is being installed/upgraded?

mnussbaum commented 10 years ago

Unfortunately my commit will still run the kill command even if the package doesn't need to be installed, all it does is prevent the kill from running if there are no virtualbox processes going.

ocxo commented 10 years ago

Should probably merge this or something like it to stop killing vbox but is there a better way to do this in Puppet? cc @rafaelfranca

rafaelfranca commented 10 years ago

Maybe we should use notify/subscribe

mnussbaum commented 10 years ago

Does the kill need to happen before the installation of the new package? If not then we can remove require => Exec['Kill Virtual Box Processes'], set the kill to refreshonly and make it subscribe to the package installation.

pbrit commented 10 years ago

I think it's no longer necessary 'cause @59c51ac heals this issue.

tarebyte commented 10 years ago

If this PR is no longer necessary I'm going to close it. Feel free to reopen it.