search

boxer-project / boxer-sunrise

Sunrise on the Boxer Reconstruction Project
BSD 3-Clause "New" or "Revised" License
39 stars 2 forks source link

README: core tests require quicklisp #56

Closed cben closed 2 years ago

cben commented 2 years ago

Without this they all error: There is no package with the name QL.. (or similar)

cben commented 2 years ago

Say, would you like to add some continuous integration running the core tests on every pull request?

GitHub Actions are probably easiest, support Linux/Mac/Windows, and the free tier should be plenty.

sgithens commented 2 years ago

Up until pretty recently, having a continuous build would have been a bit gnarly since it required a full lispworks professional license to run them. There was a thread on the lispworks user group about potential configurations of the free version to maybe work. However, for the (currently small) set of tests for the boxer-sunrise-core package that runs on ecl and sbcl, it would be great to get those setup with ecl and/or sbcl.

There are also a bucket of tests written in boxer themselves that require a fully started up boxer canvas... it might be a while before those could run under something like github actions, but nonethesless I should update them in the assets repo and add some instructions on how to run them.

sgithens commented 2 years ago

Typically, you'd have QL load as part of the init file for your common lisp distro, this is accomplished by the part of the quicklisp install instructions with the command, "(ql:add-to-init-file)". With the exception of the free personal edition of LW which does not support init files. I added some explanation of this to the README along with the install list you had in this diff. Does this makes sense now?

https://github.com/boxer-project/boxer-sunrise/blob/master/README.md#setting-up-your-development-environment

sgithens commented 2 years ago

@cben Assuming you're able to run the boxer-sunrise-core tests on either ecl or sbcl locally, if you could figure out how to have these run under github actions, that'd be an amazing initial contribution ( if it's something you're interested in looking at)