search

boxer-project / boxer-sunrise

Sunrise on the Boxer Reconstruction Project
BSD 3-Clause "New" or "Revised" License
39 stars 2 forks source link

Text is visible instead of clipped in manually-resized data box #74

Open rigdern opened 3 weeks ago

rigdern commented 3 weeks ago

Repro steps

I reproed this with Boxer 3.4.18 2024-05-26 on macOS

  1. Create a data box
  2. Type the numbers 1 thru 6 into it, one per line.
  3. Manually resize the box so its height only fits the numbers 1 thru 3.

Unexpected result: The numbers at the bottom of the box (e.g. 4, 5, 6) should be clipped. Instead, they are visible.

image

You can see the bug in this boxer file: text clipping bug.box.zip

sgithens commented 3 weeks ago

Oh, this is great thanks. I think the math must be off for the fonts... or padding or something, since it does eventually clip and get scroll bars. Much of this was reworked in this last build.

sgithens commented 2 weeks ago

This is largely fixed in 00b45722e84d0040d19f64e458c3cb5bf9d211f0 , although there is still some indirectly related work I'm doing for the sizing and math of the internal scrollbar that appears when the content is clipped.

Leaving open until it's verified against the upcoming 3.4.19 build.