boxesandglue / bagme

boxes and glue made easy - a PDF rendering library for Go using boxes and glue
BSD 3-Clause "New" or "Revised" License
76 stars 2 forks source link

cssbuilder.CSSBuilder has no field or method CreateVlist #6

Open AlfredoRamos opened 3 months ago

AlfredoRamos commented 3 months ago

Hi :wave:

Thanks for your work on this library.

We've been using this for some time, however since the latest update we can't build our app anymore.

$ go build -o build/app .
# github.com/speedata/bagme/document
../../../go/pkg/mod/github.com/speedata/bagme@v0.0.0-20231122194752-d1948a8d651e/document/document.go:82:22: d.cssbuilder.CreateVlist undefined (type *cssbuilder.CSSBuilder has no field or method CreateVlist)

We detected this with golangci-lint after upgrading the library:

$ golangci-lint run
[REDACTED].go:25:2: could not import github.com/speedata/bagme/document (-: # github.com/speedata/bagme/document
../../../go/pkg/mod/github.com/speedata/bagme@v0.0.0-20231122194752-d1948a8d651e/document/document.go:82:22: d.cssbuilder.CreateVlist undefined (type *cssbuilder.CSSBuilder has no field or method CreateVlist)) (typecheck)                                                                               
        "github.com/speedata/bagme/document"
        ^

And looking in the commit history, it was removed in commit 53a959b.

Our setup:

pgundlach commented 3 months ago

I will push my local changes as soon as possible, probably on Monday, I have changed a lot and it might break things, but I will correct the mistakes...

pgundlach commented 3 months ago

Thank you very much for the bug report!

pgundlach commented 3 months ago

I have updated some packages, but there are still some loose ends. I will keep working on it the next days hopefully