search

boxuancui / DataExplorer

Automate Data Exploration and Treatment
http://boxuancui.github.io/DataExplorer/
Other
512 stars 88 forks source link

Added intuitive colors and color option #173

Closed davidr9708 closed 1 year ago

davidr9708 commented 2 years ago

  1. I added more intuitive colors to identify the state of the colors to avoid any kind of MISLEADING interpretation. Ex: "Red = remove" is more intuitive to know that column needs to be removed than the default ggplot colors (blue or pink).

  2. I added a color option if anyone wants to use other colors (which might be more intuitive for them)

davidr9708 commented 2 years ago

My pull also solves the inconsistency problem mentioned here: https://github.com/boxuancui/DataExplorer/issues/129

boxuancui commented 1 year ago

Hi @davidr9708 , would you mind pulling your PR into the latest master, since there are some updates in the same file. Apologies for the inconvenience.

davidr9708 commented 1 year ago

Don't worry, I just pulled it with the new updates of the master branch, please, I'm sure there's not any problem but please, test it before merging it

boxuancui commented 1 year ago

Thank you so much @davidr9708 ! I will merge within a few days. Having a busy week and thanks for your patience!

boxuancui commented 1 year ago

Duplicate of #177