search

boxwise / boxtribute

The code base for Boxtribute 2.0, a humanitarian aid web application making it easy to source, store and distribute goods to people in need in a fair and dignified way
https://www.boxtribute.org/
Apache License 2.0
31 stars 12 forks source link

Improved FE DX #1460

Closed fhenrich33 closed 1 month ago

fhenrich33 commented 1 month ago

Follow up to fix linting errors on CI FE build step: https://github.com/boxwise/boxtribute/pull/1462

Task to implement Turbo repo: https://trello.com/c/r7bet14a/1483-20-fe-migrate-to-turbo-repo

fhenrich33 commented 1 month ago

2.0 FE: fix automated linting, formatting and type checking in FE before commiting

aerinsol commented 1 month ago

@pylipp could you take a neutral look at this and see if the changes here match the ADR (you can mark this as FE hours)? It would be great if you could make a note of any implementation differences to what was proposed in your review as well. If you don't feel like you're the right person for this please feel free to pass it to @HaGuesto .

@jlin95 , once @pylipp or @HaGuesto have reviewed this, do feel free to do the same an include a functional view by testing it out on your local environment ;)

pylipp commented 1 month ago

@pylipp could you take a neutral look at this and see if the changes here match the ADR (you can mark this as FE hours)? It would be great if you could make a note of any implementation differences to what was proposed in your review as well. If you don't feel like you're the right person for this please feel free to pass it to @HaGuesto .

@aerinsol I can see that husky and lint-staged are in-place as agreed in the ADR. :+1: