search

boxwise / boxtribute

The code base for Boxtribute 2.0, a humanitarian aid web application making it easy to source, store and distribute goods to people in need in a fair and dignified way
https://www.boxtribute.org/
Apache License 2.0
33 stars 11 forks source link

Improved FE DX: linting fixes #1462

Closed fhenrich33 closed 2 months ago

fhenrich33 commented 3 months ago

Follow up for https://github.com/boxwise/boxtribute/pull/1460 to fix linting errors on CI FE build step.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 85.65%. Comparing base (4da7121) to head (27c1674).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1462 +/- ## ========================================== + Coverage 85.64% 85.65% +0.01% ========================================== Files 231 231 Lines 21920 21903 -17 Branches 1911 1911 ========================================== - Hits 18774 18762 -12 + Misses 3109 3104 -5 Partials 37 37 ``` | [Flag](https://app.codecov.io/gh/boxwise/boxtribute/pull/1462/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=boxwise) | Coverage Δ | | |---|---|---| | [backend](https://app.codecov.io/gh/boxwise/boxtribute/pull/1462/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=boxwise) | `99.16% <ø> (ø)` | | | [frontend](https://app.codecov.io/gh/boxwise/boxtribute/pull/1462/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=boxwise) | `82.46% <ø> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=boxwise#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jamescrowley commented 2 months ago

@fhenrich33 @pylipp anything I can do to help get this and/or #1460 ready to be merged? :)

fhenrich33 commented 2 months ago

@fhenrich33 @pylipp anything I can do to help get this and/or #1460 ready to be merged? :)

@jamescrowley Me and @HaGuesto are going to review and address this soon!

pylipp commented 2 months ago

2.0 FE: fix automated linting, formatting and type checking in FE before commiting