search

boxwise / boxtribute

The code base for Boxtribute 2.0, a humanitarian aid web application making it easy to source, store and distribute goods to people in need in a fair and dignified way
https://www.boxtribute.org/
Apache License 2.0
31 stars 12 forks source link

Feature: Tags history #1472

Closed pylipp closed 4 days ago

pylipp commented 1 month ago
pylipp commented 1 month ago

2.0/dropapp: implement temporal awareness about adding/removing tags

codecov[bot] commented 6 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 85.59%. Comparing base (0317b05) to head (14f14ab). Report is 73 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1472 +/- ## ======================================= Coverage 85.59% 85.59% ======================================= Files 232 232 Lines 21710 21727 +17 Branches 1916 1920 +4 ======================================= + Hits 18582 18597 +15 - Misses 3088 3090 +2 Partials 40 40 ``` | [Flag](https://app.codecov.io/gh/boxwise/boxtribute/pull/1472/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=boxwise) | Coverage Δ | | |---|---|---| | [backend](https://app.codecov.io/gh/boxwise/boxtribute/pull/1472/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=boxwise) | `99.02% <ø> (-0.05%)` | :arrow_down: | | [frontend](https://app.codecov.io/gh/boxwise/boxtribute/pull/1472/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=boxwise) | `82.35% <ø> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=boxwise#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

HaGuesto commented 6 days ago

functional review

@pylipp There is only one case where I'd probably change something. I would not show Box history items about assigning tags on the timestamp when the box is created. We also do not show the selected product at the moment of creation in the box history and this would end up confusing when tags are assigned before the box is created. image

Therefore, I'd remove the assign tags entries from the box history when the box is created.

pylipp commented 6 days ago

I agree that it might be confusing to see the created-record entries as more recent in the history. I thought this might be solved by grouping history entries with identical timestamp (tagged you in trello).

If you think this is not sufficient, I'll try to make the assigned-tag entries that belong to creation disappear. I think the easiest way is to not set the created-fields of TagsRelations when creating a box. Then these fields would only be set if an existing box is updated with tags.