boxwise / boxtribute

The code base for Boxtribute 2.0, a humanitarian aid web application making it easy to source, store and distribute goods to people in need in a fair and dignified way
https://www.boxtribute.org/
Apache License 2.0
31 stars 12 forks source link

Add tracking by image download type #1491

Closed jlin95 closed 4 days ago

jlin95 commented 3 weeks ago

Extended heap tracking event with the image download type.

Would have liked to add tests in this iteration but couldn't run tests for FE, see thread: https://boxwise.slack.com/archives/CB1UYDGLU/p1724450618067419?thread_ts=1724361187.607409&cid=CB1UYDGLU - will definitely add tests when I can address this.

jlin95 commented 3 weeks ago

@HaGuesto not an urgent PR :)

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 85.59%. Comparing base (807f0ba) to head (8a78a92). Report is 86 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1491 +/- ## ======================================= Coverage 85.59% 85.59% ======================================= Files 232 232 Lines 21707 21707 Branches 1914 1914 ======================================= Hits 18580 18580 Misses 3088 3088 Partials 39 39 ``` | [Flag](https://app.codecov.io/gh/boxwise/boxtribute/pull/1491/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=boxwise) | Coverage Δ | | |---|---|---| | [backend](https://app.codecov.io/gh/boxwise/boxtribute/pull/1491/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=boxwise) | `99.07% <ø> (ø)` | | | [frontend](https://app.codecov.io/gh/boxwise/boxtribute/pull/1491/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=boxwise) | `82.35% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=boxwise#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jlin95 commented 2 weeks ago

Hey @HaGuesto, I did that when I did local testing. Do you need me to modify the getHeap function further to include extra logging?

jlin95 commented 1 week ago

I can't merge this PR, so you'd need to merge it or someone else @HaGuesto :) (It says The base branch restricts merging to authorized users.)