boxwise / boxtribute

The code base for Boxtribute 2.0, a humanitarian aid web application making it easy to source, store and distribute goods to people in need in a fair and dignified way
https://www.boxtribute.org/
Apache License 2.0
31 stars 12 forks source link

Allow tests to pass on different timezone #1497

Closed jamescrowley closed 2 weeks ago

jamescrowley commented 3 weeks ago

Some asserts such as the one used in https://github.com/boxwise/boxtribute/blob/master/front/src/views/Transfers/ShipmentsOverview/ShipmentsOverview.test.tsx#L70 assumes views show dates in UTC (or at least in a timezone that has the same date). This means these tests fail when running locally in a different timezone.

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 85.59%. Comparing base (2fe48e3) to head (0b5ea90). Report is 5 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1497 +/- ## ======================================= Coverage 85.59% 85.59% ======================================= Files 232 232 Lines 21710 21710 Branches 1916 1916 ======================================= Hits 18582 18582 Misses 3088 3088 Partials 40 40 ``` | [Flag](https://app.codecov.io/gh/boxwise/boxtribute/pull/1497/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=boxwise) | Coverage Δ | | |---|---|---| | [backend](https://app.codecov.io/gh/boxwise/boxtribute/pull/1497/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=boxwise) | `99.07% <ø> (ø)` | | | [frontend](https://app.codecov.io/gh/boxwise/boxtribute/pull/1497/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=boxwise) | `82.34% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=boxwise#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.