search

boxwise / boxtribute

The code base for Boxtribute 2.0, a humanitarian aid web application making it easy to source, store and distribute goods to people in need in a fair and dignified way
https://www.boxtribute.org/
Apache License 2.0
33 stars 11 forks source link

Show loading on global preferences loading #1504

Closed fhenrich33 closed 2 months ago

fhenrich33 commented 2 months ago

Branched out from https://github.com/boxwise/boxtribute/pull/1496

fhenrich33 commented 2 months ago

Bug 2.0 show loading state if necessary globalPreferences are not loaded yet

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 85.79%. Comparing base (cdac524) to head (893a80b). Report is 19 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1504 +/- ## ========================================== + Coverage 85.59% 85.79% +0.19% ========================================== Files 232 232 Lines 21710 21725 +15 Branches 1916 1917 +1 ========================================== + Hits 18582 18638 +56 + Misses 3088 3048 -40 + Partials 40 39 -1 ``` | [Flag](https://app.codecov.io/gh/boxwise/boxtribute/pull/1504/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=boxwise) | Coverage Δ | | |---|---|---| | [backend](https://app.codecov.io/gh/boxwise/boxtribute/pull/1504/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=boxwise) | `99.07% <ø> (ø)` | | | [frontend](https://app.codecov.io/gh/boxwise/boxtribute/pull/1504/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=boxwise) | `82.59% <ø> (+0.24%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=boxwise#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.