boxwise / boxtribute

The code base for Boxtribute 2.0, a humanitarian aid web application making it easy to source, store and distribute goods to people in need in a fair and dignified way
https://www.boxtribute.org/
Apache License 2.0
33 stars 11 forks source link

Fix console warning in browser re key usage #1530

Closed jamescrowley closed 1 month ago

jamescrowley commented 2 months ago

Key prop needs to be explicit, not exposed via a spread. These were causing errors in the console of the browser:

Screenshot 2024-09-13 at 19 07 05

when accessing http://localhost:3000/bases/1/transfers/shipments

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 85.86%. Comparing base (9b1f140) to head (656bc86). Report is 67 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1530 +/- ## ======================================= Coverage 85.85% 85.86% ======================================= Files 229 229 Lines 21709 21715 +6 Branches 1927 1927 ======================================= + Hits 18639 18645 +6 Misses 3034 3034 Partials 36 36 ``` | [Flag](https://app.codecov.io/gh/boxwise/boxtribute/pull/1530/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=boxwise) | Coverage Δ | | |---|---|---| | [backend](https://app.codecov.io/gh/boxwise/boxtribute/pull/1530/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=boxwise) | `99.07% <ø> (ø)` | | | [frontend](https://app.codecov.io/gh/boxwise/boxtribute/pull/1530/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=boxwise) | `82.68% <ø> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=boxwise#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

HaGuesto commented 1 month ago

2.0: FE improvements from James

HaGuesto commented 1 month ago

code review passed

For @fhenrich33 to merge when he thinks fit.