boxwise / boxtribute

The code base for Boxtribute 2.0, a humanitarian aid web application making it easy to source, store and distribute goods to people in need in a fair and dignified way
https://www.boxtribute.org/
Apache License 2.0
31 stars 12 forks source link

Stop logging expected GraphQL errors in test output #1535

Open jamescrowley opened 1 week ago

jamescrowley commented 1 week ago

The current test set up intercepts GraphQL errors to print them as output. This is useful, as they warn about missing mock data and other errors. However, these messages are mixed up in 'expected' failures that we've set up in the tests themselves.

This PR switches to separate classes for our fake errors so we can exclude them from the console output.

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 85.85%. Comparing base (52e1022) to head (9b1046a).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1535 +/- ## ======================================= Coverage 85.85% 85.85% ======================================= Files 229 229 Lines 21709 21709 Branches 1927 1927 ======================================= Hits 18639 18639 Misses 3034 3034 Partials 36 36 ``` | [Flag](https://app.codecov.io/gh/boxwise/boxtribute/pull/1535/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=boxwise) | Coverage Δ | | |---|---|---| | [backend](https://app.codecov.io/gh/boxwise/boxtribute/pull/1535/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=boxwise) | `99.07% <ø> (ø)` | | | [frontend](https://app.codecov.io/gh/boxwise/boxtribute/pull/1535/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=boxwise) | `82.68% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=boxwise#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.