search

boxwise / boxwise_wms

1 stars 4 forks source link

Is __init__.py conform with the odoo contribution guidelines? #92

Open HaGuesto opened 5 years ago

HaGuesto commented 5 years ago

It seems that __init__.py needs to be refactored. There are functions defined which are not connected to any model. I'm not sure if it agrees with the whole object oriented approach of odoo.

Maybe we need to refactor here, @jamescrowley?

jamescrowley commented 5 years ago

The whole thing is a nasty hack to try and work-around how we are populating 'configuration' data in the system that is also mutable. Would love to know what the Odoo-idomatic way of achieving this is.

HaGuesto commented 5 years ago

I see :) Configuration IS nasty. I'll get in touch with my odoo dev company here in Berlin. I had this problem, too.