search

boxybird / inertia-wordpress

The WordPress adapter for Inertia.js.
170 stars 26 forks source link

require version 8 of illuminate/support #6

Closed patlamontagne closed 3 years ago

patlamontagne commented 3 years ago

Hey. First off, thanks for this package.

I think using the latest version of illuminate/support would be nice. (or dropping it's usage completely)

I'm currently using illuminate/collections^8 in my project and its internal dependency of illuminate/support^8 conflicts with yours.

I tried it and it works fine on my own fork.

Let me know what you think about it.

boxybird commented 3 years ago

Thank you for the kind words!

I think dropping it would make the most sense.

In the beginning, I was trying to mirror the Laravel adapter as closely as possible, but that was a silly move. WordPress !== Laravel. Let me spend some time refactoring to use the PHP standard library.

patlamontagne commented 3 years ago

I agree with you. I went ahead and replaced support, let me close this PR and open a new one.

boxybird commented 3 years ago

Thanks for the PR!