search

boyan-soubachov / tastyworks_api

An unofficial, reverse-engineered Python API for tastyworks.
Apache License 2.0
209 stars 79 forks source link

Dough URI Does Not Respond #46

Closed bandwiches closed 4 years ago

bandwiches commented 4 years ago

Describe the bug Pretty sure the URI for the Dough module was deprecated.

To Reproduce Steps to reproduce the behavior:

  1. Make a request to the URI (https://trade.dough.com/api/public_watchlists?include_synthetic=true)
  2. See no response from server

Expected behavior A response from the server

Additional context Any HTTP GET function will reproduce the error. The server is still available and responding, but the URI does not.

boyan-soubachov commented 4 years ago

Good point. I haven't had the chance to maintain this repo in a while. If you would like to do a PR, I would be happy to review it :)

bandwiches commented 4 years ago

I would love to, but I don't know what the correct URI is. I was actually looking for that exact call when I found this repo and got really excited! If you can provide any direction (even a google search) on how to figure that out, I'd be glad to correct and submit a pull!

boyan-soubachov commented 4 years ago

One way is to open either of their clients (web, app, desktop) and analyse the traffic going through. Many browsers have such tools.

bandwiches commented 4 years ago

Is that the more-or-less the best approach? I'm actually a network engineer so a lot of that is familiar to me, I just assumed there was a better way to do it πŸ˜… but if that's all it takes, I can definitely look further into it.

boyan-soubachov commented 4 years ago

That’s about it. πŸ™‚. If you have a different idea, please share πŸ™‚

On 8 May 2020, at 00:00, bandwiches notifications@github.com wrote:

ο»Ώ Is that the more-or-less the best approach? I'm actually a network engineer so a lot of that is familiar to me, I just assumed there was a better way to do it πŸ˜… but if that's all it takes, I can definitely look further into it.

β€” You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.

bandwiches commented 4 years ago

Hey sorry for the delay, but I got a quick update on this. Turns out, the endpoints are now hosted under the TastyWorks API. I do have the URI's, but since this package has a separate Dough module, I wasn't quite sure how you wanted me to update the package with this update?

boyan-soubachov commented 4 years ago

I’m happy for you to move those endpoints and their objects out of the dough package and into the main tastyworks one πŸ™‚

On 12 May 2020, at 23:07, bandwiches notifications@github.com wrote:

ο»Ώ Hey sorry for the delay, but I got a quick update on this. Turns out, the endpoints are now hosted under the TastyWorks API. I do have the URI's, but since this package has a separate Dough module, I wasn't quite sure how you wanted me to update the package with this update?

β€” You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.

bandwiches commented 4 years ago

haha! I'll see what I can do!

bandwiches commented 4 years ago

I hope I'm not making this more trouble than it's worth. I haven't actually used this package but I have referenced it for a personal project. I'm not exactly adept enough to run the test modules but hopefully this is a good start! Pull Request

boyan-soubachov commented 4 years ago

That's not a problem. I left a comment on the PR, I think we should move the discussion there