boyan-soubachov / tastyworks_api

An unofficial, reverse-engineered Python API for tastyworks.

Apache License 2.0

208 stars 79 forks source link

History pulling #63

Open git4unrealnondev opened 3 years ago

git4unrealnondev commented 3 years ago

Describe the bug A clear and concise description of what the bug is.

To Reproduce Steps to reproduce the behavior: Tastyworks API currently only pulls 1 page of data. Their needs to be a way to iterate through the pages in order to pull more data. Should be under pagination in json data.

Expected behavior Pull ALL transactions from tastyworks.

bandwiches commented 3 years ago

56 supports this, but hasn't been pulled yet, it looks like it would still be valid.

Not sure what the consensus is on storing TastyAPISession inside TradingAccount since it contains credentials. I feel like there should at least be some conversation about how accessible session credentials are and when/where they're stored.

bandwiches commented 3 years ago

PR #64 is a mix of #56 without a complete overhaul of the object.