Closed perigvennetier closed 3 years ago
Closing this as I will have a better one soon.
I closed this PR because what I submitted was very messy. I am taking in all the comments and will provide the update I had made piecemeal in other clearer smaller PRs so it's easier to digest. I submitted the Greeks one already and will continue to work on this. This is getting close to being usable in a actual algo I have in mind :D
Problem addressed
The example.py file was not very easy to understand for new people and was not showing a lot of the functionalities. Some of the information for options were missing.
It may help solve these issues: https://github.com/boyan-soubachov/tastyworks_api/issues/70 https://github.com/boyan-soubachov/tastyworks_api/issues/60 https://github.com/boyan-soubachov/tastyworks_api/issues/53 https://github.com/boyan-soubachov/tastyworks_api/issues/48
Solution
I added some more examples and put some comments as well in example.py. Added a 'greeks' class to hold the option greeks values Added more information in the orders class as some were missing Changed 'expiry' to 'expiration_date' for clarity (this one could be reversed but I feel it's clearer this way (expiry could refer to a Weekly or Monthly expiration type). I had to update the tests as well for this one.
Checklist
PR commits have been squashed > I could not find out how to do this as I was working on my origin/master branch, hopefully it still works
All tests pass > YES
Code adheres to contributing guidelines > I believe so...