boydm / phoenix_integration

Lightweight server side integration test tools for Phoenix
Apache License 2.0
219 stars 26 forks source link

Elixir v1.10 compilation error, Kernel.is_struct/1 conflicts with local function #30

Closed ZombieHarvester closed 4 years ago

ZombieHarvester commented 4 years ago

Elixir 1.10 added Kernel.is_struct/1

==> phoenix_integration
Compiling 3 files (.ex)
warning: function is_struct/1 is unused
  lib/phoenix_integration/requests.ex:1159

== Compilation error in file lib/phoenix_integration/requests.ex ==
** (CompileError) lib/phoenix_integration/requests.ex:1159: imported Kernel.is_struct/1 conflicts with local function
    (elixir 1.10.0) src/elixir_locals.erl:94: :elixir_locals."-ensure_no_import_conflict/3-lc$^0/1-0-"/2
    (elixir 1.10.0) src/elixir_locals.erl:95: anonymous fn/3 in :elixir_locals.ensure_no_import_conflict/3
    (stdlib 3.11.1) erl_eval.erl:680: :erl_eval.do_apply/6
boydm commented 4 years ago

On it.

boydm commented 4 years ago

Fixed in master. I'll push 0.6.1 once we decide what to do with the Floki issue you pointed out a few days ago...

ZombieHarvester commented 4 years ago

I pulled the version from master. With Elixir 1.10 and Floki 0.24 tests run without issues. Thanks!