search

boydm / phoenix_markdown

Phoenix Template Engine for Markdown
MIT License
90 stars 13 forks source link

Percent-decode server tags in URI's #10

Closed WalkerMills closed 5 years ago

WalkerMills commented 5 years ago

Content inside URI's is percent-encoded rather than HTML-encoded by Earmark. In practice, this means that server tags inside links do not work. Since Earmark doesn't prettify URI strings, this is independent of smartypants processing. This is very similar to PR #9.

I further extended do_handle_smart_tags to replace all percent-encoded server tags (inside URI strings) in addition to HTML-encoded server tags. I also added a new test and fixture to make sure everything works.

This should resolve issue #8

boydm commented 5 years ago

Thank you again! Looks like I'll have to bump it up to 1.0.3. That's ok. tho.

WalkerMills commented 5 years ago

No problem. I'm always glad to contribute where I can.

WalkerMills commented 5 years ago

I compared the logs of the failed job to another successful job with the same config. It appears that it failed to start up since the first log is missing any runtime information from inside the container, and eventually the job timed out. Closed & re-opened this PR to trigger a new build.

boydm commented 5 years ago

This is now published to hex as 1.0.3