search

boyney123 / garie-lighthouse

Lighthouse Garie plugin. Polls websites to checkout performance metrics also supports webhooks.
MIT License
50 stars 24 forks source link

feat: add supoort for custom lighthouse config #3

Closed mouafa closed 5 years ago

mouafa commented 5 years ago

What: Add the ability to customize lighthouse config per URL, like this:

{
            "url": "https://www.example.com",
            "plugins": [
                {
                    "name": "lighthouse",
                    "report": true,
                    "config": {
                        "settings": {
                            "emulatedFormFactor": "desktop"
                        }
                    }
                }
            ]
        }

Why: I want lighthouse to check the benchmark for desktop only webapp, and unfortuantly it's crashing with the current config.

How:

via URL based custom config

Checklist:

codecov-io commented 5 years ago

Codecov Report

Merging #3 into master will decrease coverage by 0.15%. The diff coverage is 100%.

@@            Coverage Diff             @@
##           master       #3      +/-   ##
==========================================
- Coverage   93.33%   93.18%   -0.16%     
==========================================
  Files           5        5              
  Lines         135      132       -3     
  Branches       25       24       -1     
==========================================
- Hits          126      123       -3     
  Misses          9        9
mouafa commented 5 years ago

@boyney123 any input on this?

mouafa commented 5 years ago

I'm closing this, if anyone stumbled upon the same issue, you could try this alternative:

https://github.com/mouafa/iceberg-lighthouse