search

boynux / squid-exporter

Squid Prometheus Exporter
https://www.boynux.com/squid-exporter
MIT License
134 stars 53 forks source link

Securely Export #86

Closed Megabyte516 closed 4 months ago

Megabyte516 commented 1 year ago

Describe the bug Just would like to know if there is any plan to incorporate SSL/TLS into this exporter.

To Reproduce None

Expected behavior Allow setting up secure connection to Prometheus server

OS (please complete the following information):

Additional context Add any other context about the problem here.

boynux commented 9 months ago

Hi, I currently don't have any plans to add https/tls support, but feel free to make a pull request and I'll make sure to review it timely.

Thank you!

dswarbrick commented 5 months ago

The use of github.com/prometheus/exporter-toolkit would make this trivial to implement, as it provides helper functions for the http server configuration, defined by a config file: https://github.com/prometheus/exporter-toolkit/blob/master/docs/web-configuration.md

boynux commented 4 months ago

Thank you for the pointer, I still can't make time for this, although I agree this is a good improvement. However, will gladly review PRs if you or some else has a few spare hours to contribute to this open source project.