boyserk84 / zombie-real-time-strategy-game

Automatically exported from code.google.com/p/zombie-real-time-strategy-game
0 stars 0 forks source link

Unit Factory is not in trunk #14

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Need changes from dgg's branch to be *bold*code reviewed*bold* and forward 
integrated into the trunk.  In particular, the unit factory is needed in order 
to complete the Unit Palette.

I know you've done a lot of work since your last code review - it would be very 
helpful to get everything you've changed since we branched into the trunk.  But 
since I'm gonna be using the unit factory, I'd really like to code review.

In general, the longer you take to get your code reviewed and moved up to the 
branch, the rougher it is to get it code reviewed and integrated, so asking for 
small code reviews and moving up to trunk often is helpful.

Original issue reported on code.google.com by marc.cel...@gmail.com on 7 Mar 2011 at 9:22

GoogleCodeExporter commented 9 years ago
I have hooked it up to where I am using the Unit Factory to populate the 
palette with some boxes, one representing each unit type.  However, I need the 
Unit Factory (or some other object) to expose an interface for grabbing a 
bitmap for the unit - I'm just using grass right now.  Since you did this for 
the TileFactory, I was wondering if you could handle this in the Unit Factory 
as well.

Also, there seems to be some differences between what your UnitFactory is 
expecting in the xml and the sample xml I found in 
ZRTS\bin\x86\Debug\Content\units or in 
ZRTS\ZRTSContent\bin\x86\Debug\Content\units.  I had to comment some code out 
to get the UnitFactory to work.

Original comment by marc.cel...@gmail.com on 15 Mar 2011 at 3:45

GoogleCodeExporter commented 9 years ago
Per conversation today, marking as Fixed.

Original comment by marc.cel...@gmail.com on 15 Mar 2011 at 10:11