boyserk84 / zombie-real-time-strategy-game

Automatically exported from code.google.com/p/zombie-real-time-strategy-game
0 stars 0 forks source link

Code review request #20

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
Purpose of code changes on this branch:

ZRTS and ZRTS.Model
- Fully implementing ViewSelect and ViewSelectObserver to focus on the selected 
unit(s) by the user.
- Interaction between ViewSelect and Scenario is now conforming to the observer 
pattern. 
- New interface for ViewSelect is created (ViewSelectObserver).

ZRTS.Model
- Add (X,Y) to the "Entity" model so that all "Entity" objects will have a 
location reference.

ZRTS.Scenario
- Observer and Observable objects are now in the ZRTS.Scenario.

When reviewing my code changes, please focus on:
1.) How the observer pattern would be beneficial to the View and Model parts? 
There are some dummy functions that we have to create in order to conform with 
the observer pattern, which we may or may not be using it later.
2.) Focus on if the current features are accomplished and the code/design could 
accommodate future features.

After the review, I'll merge this branch into:
/trunk

Original issue reported on code.google.com by nkem...@gmail.com on 7 Mar 2011 at 10:38