Closed connermcd closed 11 years ago
Whoa, awesome!
I'll have a look over the PR tonight, bonus points for the vid.
Sorry to bother you, but...
Bump? :)
There are some problems with the scrolling commands. I'll fix it and resubmit. Let me know if you see any other problems, richo/nathan.
What are the problems with scrolling? Also, this is great. I have wanted this sort of functionality for a while.
The only problem I've noticed had to do with using the scrolling shortcut keys (e.g. CTRL-Y/E/D/U). The wrong song gets highlighted with the current song color sometimes. I haven't noticed any crashes or serious bugs though. I'll fix it asap but I'm busy lately. And I'm glad you like it! El jun 29, 2013 2:39 AM, "boysetsfrog" notifications@github.com escribió:
What are the problems with scrolling? Also, this is great. I have wanted this sort of functionality for a while.
— Reply to this email directly or view it on GitHubhttps://github.com/boysetsfrog/vimpc/pull/14#issuecomment-20225979 .
So I looked into this problem with scrolling and it seems it has actually been around for about 5 months since commit 35dd926. The commit only changes a few lines but changes the overall color of the playlist and causes the scrolling issue. Therefore this commit should be ready to merge and we can look into that issue.
http://youtu.be/F7369VJ7XsU