search

boysetsfrog / vimpc

Official repository for vimpc a vi/vim inspired client for the Music Player Daemon (mpd). Pull requests are welcome.
GNU General Public License v3.0
269 stars 34 forks source link

Added more metadata to info window. #20

Closed connermcd closed 11 years ago

boysetsfrog commented 11 years ago

The position item in the infowindow won't work if you navigate away from the infowindow change your selection then navigate back. Or if you open the infowindow from the browse/library etc tab. I think we need to add a function to the Playlist Buffer that returns the positions for a given song instead. If we are only using it for this window it won't matter if we have to search the entire list to get the positions. And we can cache it in the infowindow and only update it if the song's reference count changes if we have to, rather than searching the playlist every time print is called. Something like that.

connermcd commented 11 years ago

Completely agree I just took the lazy road as previously discussed. Will do :+1:

connermcd commented 11 years ago

It was a lot easier than I expected.