search

boysetsfrog / vimpc

Official repository for vimpc a vi/vim inspired client for the Music Player Daemon (mpd). Pull requests are welcome.
GNU General Public License v3.0
269 stars 34 forks source link

Return on "open" artist in libary returns "invalid song index" #3

Closed richo closed 11 years ago

boysetsfrog commented 13 years ago

Whilst this obviously shouldn't cause the bad song index error that it does, i am not sure what to do in this case with normal adding. Whilst with return it is probably still sensible to add the entire album and play it. The problem i am unsure about is if you expand the artist then on the artist do '2a'. This would then add the same album twice and that is probably a bit strange. Any thoughts on sensible behavior for this?

richo commented 13 years ago

What does 2a do if the album is not expanded? I think either the same behaviour, or potentially adding the first two songs although that's kinda vague.

boysetsfrog commented 13 years ago

I have fixed the "invlaid song index" issue in the latest svn commit, and dealt with adding/deleting on the library window as well, currently using a number won't add the same thing twice but it will primarily just add artists, as it adds the first thing it encounters then skips to the next thing it hasn't yet add, this pretty much works as intuitively as i think it can, but try it out and let me know if it seems ok. If you can confirm this is working i will close this off.

richo commented 13 years ago

Ok awesome. I've pushed your changes to github in 6142734, I'll hopefully get a chance to test it tomorrow.

boysetsfrog commented 11 years ago

This was fixed a long time ago. Closing.