search

boysetsfrog / vimpc

Official repository for vimpc a vi/vim inspired client for the Music Player Daemon (mpd). Pull requests are welcome.
GNU General Public License v3.0
269 stars 34 forks source link

Paste above below #37

Closed connermcd closed 10 years ago

connermcd commented 10 years ago

Proposed solution for #36.

boysetsfrog commented 10 years ago

Thanks. This looks good and I had actually done something similar in a branch called "paste". The problem I was having with mine though was the autoscroll behavior. I think I had it working as I wanted except for one particular case. But I don't really remember. Currently without a computer so development is slow.

connermcd commented 10 years ago

I may have run into the same problem you did. This addition seems to allow scrolling well except if you paste below on the last song of the playlist. I'm not sure what's causing this behavior, but it seems to be related to this line. I could be very wrong about that.

boysetsfrog commented 10 years ago

Yeah, that sounds like the same sort of behaviour that I remember. I think it was to do with the scroll occuring when we do the add, but the add itself is actually asynchronous and completes when mpd itself adds the song. But I don't remember exactly. Either way I am happy to merge it in, once i finally get around to releasing 0.09.1.

connermcd commented 10 years ago

Cool, thanks.