search

boysetsfrog / vimpc

Official repository for vimpc a vi/vim inspired client for the Music Player Daemon (mpd). Pull requests are welcome.
GNU General Public License v3.0
266 stars 34 forks source link

directory view: Put the previous page location in a stack #66

Closed akadaedalus closed 5 years ago

akadaedalus commented 8 years ago

My music collection is stored in multiple nested directories. For example:

mp3s/artist/album/*.mp3
mp3s/classical/composer/album/*.mp3
mp3s/singles/artist/*.mp3

When I'm navigating into the directory view of the top-level "mp3s" folder, I make my selection to go to the sub directories. When I go back, it goes back to the top of the previous page, except within the mp3s folder.

Sounds like there should be a stack (LIFO) implementation to track previous pages.

Also, for a long time I thought it didn't even work in the top level folder because I was conditioned to use the ".." to go back to the parent directory, and that goes to the top of the parent directory list. I'll understand if you want to keep it this way but it confused me to see that commit comment "Remember top level directory when browsing directory mode" and it never worked for me because I was selecting "..".

I can take a stab at a patch myself but it's been so long since I worked with C++ code I'm not sure how well I can do it.

connermcd commented 5 years ago

For clarification this is in regards to the :directory window. When traversing down into directories and then returning backward (with h) the selected path is not preserved.