search

boysetsfrog / vimpc

Official repository for vimpc a vi/vim inspired client for the Music Player Daemon (mpd). Pull requests are welcome.
GNU General Public License v3.0
269 stars 34 forks source link

Lyrics fetching doesn't work #69

Closed dkasak closed 5 years ago

dkasak commented 8 years ago

Lyrics fetching doesn't seem to work to work no matter which song I try using the latest master.

Example:

Attempting to find lyrics
Doing PCRE compilation on %artist%
Replacing %artist% in http://lyrics.wikia.com/api.php?action=lyrics&fmt=xml&func=getSong&artist=%artist%&song=%title% with Blind%20Guardian
Doing PCRE compilation on %title%
Replacing %title% in http://lyrics.wikia.com/api.php?action=lyrics&fmt=xml&func=getSong&artist=Blind%20Guardian&song=%title% with The%20Curse%20Of%20Feanor
Doing PCRE compilation on <url>(.*?)</url>
Captured http://lyrics.wikia.com/Blind_Guardian:The_Curse_Of_Feanor
Replacing <url>(.*?)</url> in <?xml version="1.0" encoding="UTF-8"?>
Doing PCRE compilation on &#039;
Doing PCRE compilation on &amp;
Doing PCRE compilation on &quot;
Doing PCRE compilation on &nbsp;
Doing PCRE compilation on ^s+
Doing PCRE compilation on s+$
Doing PCRE compilation on <div class='lyricbox'><script>.*?</script>(.*?)<!--
Doing PCRE compilation on <A HREF="(.*?)">here</A>
Captured http://www.azlyrics.com/lyrics/blindguardian/thecurseoffanor.html
Replacing <A HREF="(.*?)">here</A> in <HTML><HEAD><meta http-equiv="content-type" content="text/html;charset=utf-8">
Doing PCRE compilation on %artist%
Doing PCRE compilation on %title%
Doing PCRE compilation on <!-- start of lyrics -->(.*?)<!-- end of lyrics -->
Doing PCRE compilation on <A HREF="(.*?)">here</A>
Captured http://www.metrolyrics.com/the-curse-of-feanor-lyrics-blind-guardian.html
Replacing <A HREF="(.*?)">here</A> in <HTML><HEAD><meta http-equiv="content-type" content="text/html;charset=utf-8">
Doing PCRE compilation on <A HREF="(.*?)">here</A>
Captured http://www.metrolyrics.com/the-curse-of-feanor-lyrics-blind-guardian.html
Replacing <A HREF="(.*?)">here</A> in <HTML><HEAD><meta http-equiv="content-type" content="text/html;charset=utf-8">
Doing PCRE compilation on <A HREF="(.*?)">here</A>
Captured http://www.metrolyrics.com/the-curse-of-feanor-lyrics-blind-guardian.html
Replacing <A HREF="(.*?)">here</A> in <HTML><HEAD><meta http-equiv="content-type" content="text/html;charset=utf-8">
Doing PCRE compilation on %artist%
Doing PCRE compilation on %title%
Doing PCRE compilation on <div id="lyrics-body">(.*?)</div>
Doing PCRE compilation on <A HREF="(.*?)">here</A>
Captured https://www.justsomelyrics.com/574628/blind-guardian-the-curse-of-f%C3%ABanor-lyrics.html
Replacing <A HREF="(.*?)">here</A> in <HTML><HEAD><meta http-equiv="content-type" content="text/html;charset=utf-8">
Doing PCRE compilation on %artist%
Doing PCRE compilation on %title%
Doing PCRE compilation on <div class="core-left">(.*?)</div>
Doing PCRE compilation on <A HREF="(.*?)">here</A>
Captured http://www.metrolyrics.com/the-curse-of-feanor-lyrics-blind-guardian.html
Replacing <A HREF="(.*?)">here</A> in <HTML><HEAD><meta http-equiv="content-type" content="text/html;charset=utf-8">
Event triggered: LyricsLoaded

vimpc then just reports No lyrics were found.

Can others reproduce this?

nzachow commented 8 years ago

I don't know how get this log but I have the same issue. The version I'm using is vimpc 0.09.1.

connermcd commented 5 years ago

Sorry for the delayed response. Seems to be fixed by https://github.com/boysetsfrog/vimpc/commit/99f1c4534f7c75a57a982f103f519aaf1c7b0cbf Please test and let me know if I can close this.

dkasak commented 5 years ago

Just a heads up: I don't use vimpc anymore, so someone else should test this.

connermcd commented 5 years ago

Thanks for the response! Tested on 20 obscure albums and seems to be working. Closing this. Come back and see us :tongue: