boyter / lc

licensechecker (lc) a command line application which scans directories and identifies what software license things are under producing reports as either SPDX, CSV, JSON, XLSX or CLI Tabular output. Dual-licensed under MIT or the UNLICENSE.
GNU Affero General Public License v3.0
124 stars 17 forks source link

JSON output is invalid #5

Closed sschuberth closed 6 years ago

sschuberth commented 6 years ago

JSON output is something like

[{Apache-2.0 0.9820416112200386} {ECL-2.0 0.9816067839861887} {CC-BY-NC-ND-3.0 0.9133121766992705} {CC-BY-NC-3.0 0.9132930147828987} {CC-BY-3.0 0.9115045535047256} {CC-BY-NC-SA-3.0 0.9111092719068973} {CC-BY-ND-3.0 0.9107656330507543} {CC-BY-SA-3.0 0.9076555881980038} {CC-BY-NC-2.5 0.9068909320860387} {CC-BY-NC-2.0 0.9050273550999453} {CC-BY-NC-SA-2.5 0.9043774260896892} {CC-BY-NC-SA-2.0 0.9029690938226045} {CC-BY-NC-ND-2.5 0.902856917776841} {RPL-1.1 0.9024687553399653} {OSL-2.1 0.9021600539592493} {CC-BY-NC-ND-2.0 0.9013231741145554} {OSL-3.0 0.9012500699047303} {CC-BY-NC-1.0 0.9011283469263592} {OSL-2.0 0.9010935813608286} {CC-BY-2.5 0.9001591349804541} {AFL-3.0 0.9000890602151572} {CC-BY-NC-SA-1.0 0.8997149521547787} {RPSL-1.0 0.8996518246913179} {NPOSL-3.0 0.8994258323278262} {OSL-1.1 0.8991596162122619} {CC-BY-2.0 0.8980891540798946} {CC-BY-SA-2.5 0.8978961638045134} {CC-BY-ND-2.5 0.8964275017374166} {CC-BY-SA-2.0 0.8961860584816612} {CC-BY-SA-1.0 0.8948504529310831} {CC-BY-ND-2.0 0.8941912407814255} {CC-BY-1.0 0.8935086935594703} {Watcom-1.0 0.892030153131385} {APL-1.0 0.8919370580758877} {AFL-2.1 0.8914185431694561} {CC-BY-NC-ND-1.0 0.8895559886703055} {OSL-1.0 0.8893766813693182} {AFL-2.0 0.8891941263749268} {APSL-2.0 0.8883139003604398} {OCLC-2.0 0.8847764289194198} {MPL-2.0 0.8833798926249776} {MPL-2.0-no-copyleft-exception 0.8833798926249776} {CC-BY-ND-1.0 0.8809103866050997} {EPL-2.0 0.8721849134808276} {SCEA 0.8550701488756585} {LPL-1.02 0.8550067529807} {Artistic-2.0 0.8547973447224115} {LPL-1.0 0.8542530658488672} {CPL-1.0 0.8509001155583861} {EPL-1.0 0.8505800953898698}]

This is not valid JSON. Key / value pairs in a map should be quoted and separated by a colon.

boyter commented 6 years ago

I suspect related to #4

Its a mistake I made about dealing with files not folders... I might drop the file support for the moment to resolve it.

sschuberth commented 6 years ago

Ah, confirmed that valid JSON is being written if the input is a directory.

boyter commented 6 years ago

Yeah its a mistake, I forgot I even put that in there. The joy of releasing code to the world!