search

boyter / scc

Sloc, Cloc and Code: scc is a very fast accurate code counter with complexity calculations and COCOMO estimates written in pure Go
MIT License
6.57k stars 262 forks source link

Update Dockerfile to use alpine:3.20 #470

Closed coiouhkc closed 4 months ago

coiouhkc commented 4 months ago

Update Dockerfile to use alpine:3.20 both for builder and resulting image, caused by aquasec/trivy vuln. scanner issues with git, see #469

boyter commented 4 months ago

Cheers for that.

coiouhkc commented 4 months ago

Thanks for merging! When do you plan to release a new version of the docker image?

boyter commented 4 months ago

I don't actually have control of that... I don't think... unless its something done in github somehow. If thats the case let me know how and ill do it instantly.

coiouhkc commented 4 months ago

@boyter - i thought you merged the feature from https://github.com/lhoupert/scc-in-docker (also https://github.com/lhoupert/scc and https://github.com/boyter/scc/pull/425), at least i see a pipeline at https://github.com/boyter/scc/blob/master/.github/workflows/docker-publish.yml

I initially used the docker image of @lhoupert, but i'm not sure, whether https://github.com/lhoupert/scc is still maintained.

boyter commented 4 months ago

Well my lack of github knowledge is showing here. Ill have to have a look to see what I need to do in that case.

dbaggerman commented 4 months ago

@boyter, your docker images are listed here: https://github.com/boyter/scc/pkgs/container/scc

Looks like it's based on the release version, so a 3.3.5 version would get built with the updated dockerfile.

lhoupert commented 4 months ago

@boyter - i thought you merged the feature from https://github.com/lhoupert/scc-in-docker (also https://github.com/lhoupert/scc and https://github.com/boyter/scc/pull/425), at least i see a pipeline at https://github.com/boyter/scc/blob/master/.github/workflows/docker-publish.yml

I initially used the docker image of @lhoupert, but i'm not sure, whether https://github.com/lhoupert/scc is still maintained.

Hi I am not maintaining this fork, it was mostly to build and test my PR. I will archive it to avoid confusion.

boyter commented 4 months ago

Neat so nothing for me to do then. Perfect.