search

boywithkeyboard-archive / cheetah1

A framework for the modern web. (NO LONGER MAINTAINED)
https://cheetah.mod.land
Apache License 2.0
192 stars 1 forks source link

Update readme.md versionings #199

Closed TheYuriG closed 1 year ago

TheYuriG commented 1 year ago

Updated versioning examples on README.md and also pinned import to avoid deno warning for using unpinned version.

This PR doesn't perform any code changes and therefore deno task check wasn't run.

boywithkeyboard commented 1 year ago

@TheYuriG did you run deno fmt though?

TheYuriG commented 1 year ago

@TheYuriG did you run deno fmt though?

No, I didn't. I only made inline changes and added no new lines, so didn't think it would be necessary, don't see what could be formatted differently in it.

TheYuriG commented 1 year ago

I've also seen (on the documentation website) that you mention not versioning your examples, I assume to not need to update it on all files every time you push a new version, so you might want to edit this PR before merging and removing the version pin.

boywithkeyboard commented 1 year ago

@TheYuriG I don't see any reason to apply these changes. Those two versions you edited are clearly just examples and the "Sneak Peek" section shouldn't include the latest version tag for the reason you already mentioned before.

TheYuriG commented 1 year ago

LGTM.

boywithkeyboard commented 1 year ago

That's also why I explicitly used v0.1 to make it clear.

TheYuriG commented 1 year ago

That's also why I explicitly used v0.1 to make it clear.

It just felt really outdated to still use v0.1 as an example with this much development having happened since. I would have at least bumped to v1.0 instead, but you do you.

boywithkeyboard commented 1 year ago

@TheYuriG I added these version examples at v1.3 iirc, I used v0.1 to make it clear it's an example.